Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#602] Update outdated dependency versions #604

Merged
merged 2 commits into from
Mar 13, 2025
Merged

[#602] Update outdated dependency versions #604

merged 2 commits into from
Mar 13, 2025
+39 −37

Conversation

kaungkhantsoe
Copy link
Contributor

@kaungkhantsoe kaungkhantsoe commented Feb 26, 2025 •
edited by coderabbitai bot
Loading

#602

What happened 👀

Updated outdated dependency versions for both template and sample compose

Insight 📝

We will update composeNavigation in a separate PR from this disscussion

Proof Of Work 📹

All pipeline checks should pass

Summary by CodeRabbit

  • Chores
    • Upgraded multiple third-party dependencies, including datastore, gradle, hilt, kotlin, and mockk, to their latest versions.
    • These updates help ensure a smoother and more reliable experience on supported Android platforms.

@kaungkhantsoe kaungkhantsoe added this to the 3.32.0 milestone Feb 26, 2025
@kaungkhantsoe kaungkhantsoe self-assigned this Feb 26, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2025 •
edited
Loading

Walkthrough

This pull request updates dependency versions in two version catalog files: sample-compose/gradle/libs.versions.toml and template-compose/gradle/libs.versions.toml. The updated versions include datastore (1.1.2 to 1.1.3), gradle (8.8.1 to 8.8.2), hilt (2.52 to 2.53), kotlin (2.1.0 to 2.1.10), and mockk (1.13.5 to 1.13.8).

Changes

Files Change Summary
sample-compose/gradle/libs.versions.toml, template-compose/gradle/libs.versions.toml Updated versions for datastore (1.1.2→1.1.3), gradle (8.8.1→8.8.2), hilt (2.52→2.53), kotlin (2.1.0→2.1.10), mockk (1.13.5→1.13.8)

Possibly related PRs

Suggested reviewers

  • hoangnguyen92dn
  • sleepylee
  • win-than-htike
  • Johnsonmaung
  • luongvo
  • toby-thanathip
  • RkNaing
  • manh-t
  • minhnimble
  • eeeeaa
  • chornerman
  • ryan-conway
  • thawzintoe-ptut

Poem

I'm a hopper in the code meadow today,
Nibbling through versions in a playful way,
Dependencies updated with each gentle bite,
Gradle, libraries, all feeling light,
I binky in joy with every line in sight,
Celebrating updates under the moon's soft ray! 🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d91fffa and 1772be0.

📒 Files selected for processing (4)
  • sample-compose/gradle/libs.versions.toml (1 hunks)
  • template-compose/gradle/libs.versions.toml (1 hunks)
  • sample-compose/gradle/libs.versions.toml (1 hunks)
  • template-compose/gradle/libs.versions.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • sample-compose/gradle/libs.versions.toml
  • template-compose/gradle/libs.versions.toml
  • template-compose/gradle/libs.versions.toml
  • sample-compose/gradle/libs.versions.toml
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Review pull request
  • GitHub Check: Verify newproject script
  • GitHub Check: Run Detekt and unit tests
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot temporarily deployed to template-compose February 26, 2025 10:39 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2025 •
edited
Loading

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.04%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

libs.versions.toml
libs.versions.toml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@kaungkhantsoe kaungkhantsoe force-pushed the chore/602-update-outdated-dependency-versions branch from 6405224 to 7254956 Compare February 26, 2025 10:51
@coderabbitai coderabbitai bot temporarily deployed to template-compose February 26, 2025 10:53 Inactive
@kaungkhantsoe kaungkhantsoe force-pushed the chore/602-update-outdated-dependency-versions branch from 7254956 to d91fffa Compare March 11, 2025 07:19
github-actions[bot]
github-actions bot reviewed Mar 11, 2025
View reviewed changes
template-compose/gradle/libs.versions.toml
composeBom = "2023.09.02"
chucker = "4.0.0"
composeBom = "2025.02.00"
# @kaungkhantsoe Will update in a separate PR
composeNavigation = "2.5.3"
Copy link

@github-actions github-actions bot Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of androidx.navigation:navigation-compose than 2.5.3 is available: 2.8.8

ryan-conway
ryan-conway reviewed Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@ryan-conway ryan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM 🙇🏻

@coderabbitai coderabbitai bot temporarily deployed to template-compose March 11, 2025 10:19 Inactive
github-actions[bot]
github-actions bot reviewed Mar 11, 2025
View reviewed changes
template-compose/gradle/libs.versions.toml
gradle = "8.8.0"
hilt = "2.52"
hiltNavigation = "1.0.0"
gradle = "8.8.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of com.android.application than 8.8.2 is available: 8.9.0

github-actions[bot]
github-actions bot reviewed Mar 11, 2025
View reviewed changes
template-compose/gradle/libs.versions.toml
gradle = "8.8.0"
hilt = "2.52"
hiltNavigation = "1.0.0"
gradle = "8.8.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of com.android.library than 8.8.2 is available: 8.9.0

@ryan-conway ryan-conway merged commit 30c94b7 into develop Mar 13, 2025
5 of 6 checks passed
@ryan-conway ryan-conway deleted the chore/602-update-outdated-dependency-versions branch March 13, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@chornerman chornerman chornerman approved these changes

@eeeeaa eeeeaa eeeeaa approved these changes

@ryan-conway ryan-conway ryan-conway approved these changes

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@Johnsonmaung Johnsonmaung Awaiting requested review from Johnsonmaung Johnsonmaung is a code owner

@luongvo luongvo Awaiting requested review from luongvo luongvo is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@RkNaing RkNaing Awaiting requested review from RkNaing RkNaing is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@thawzintoe-ptut thawzintoe-ptut Awaiting requested review from thawzintoe-ptut thawzintoe-ptut is a code owner

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip is a code owner

@win-than-htike win-than-htike Awaiting requested review from win-than-htike win-than-htike is a code owner

Assignees

@kaungkhantsoe kaungkhantsoe

Labels
type : chore
Projects
None yet
Milestone
3.32.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kaungkhantsoe @chornerman @eeeeaa @ryan-conway